[krbdev.mit.edu #6377] SVN Commit

Tom Yu via RT rt-comment at krbdev.mit.edu
Wed Feb 18 19:37:18 EST 2009


pull up r21920, r21922, r21926 from trunk

 ------------------------------------------------------------------------
 r21926 | raeburn | 2009-02-09 15:39:54 -0500 (Mon, 09 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/kfree.c

 ticket: 6377

 Fix one more case of an explicit null check before calling a free
 function that does the null check.

 Also, use krb5_free_keyblock_contents instead of open-coding all the
 work (and not trying hard enough to clear the memory).
 ------------------------------------------------------------------------
 r21922 | raeburn | 2009-02-09 13:13:08 -0500 (Mon, 09 Feb 2009) | 3 lines
 Changed paths:
    M /trunk/src/lib/krb5/os/free_krbhs.c

 ticket: 6377

 Provide omitted return value in last change.
 ------------------------------------------------------------------------
 r21920 | raeburn | 2009-02-09 12:53:21 -0500 (Mon, 09 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/free_rtree.c
    M /trunk/src/lib/krb5/krb/init_ctx.c
    M /trunk/src/lib/krb5/krb/kfree.c
    M /trunk/src/lib/krb5/krb/preauth2.c
    M /trunk/src/lib/krb5/os/free_krbhs.c
    M /trunk/src/lib/krb5/os/promptusr.c

 ticket: 6377
 subject: make krb5_free_* functions ignore NULL

 This makes them safer to call in various contexts where NULL may leak
 through, and makes analysis easier.

 Also, remove some checks for NULL before calling a free routine that
 will also check for NULL.
 ------------------------------------------------------------------------

http://src.mit.edu/fisheye/changelog/krb5/?cs=22032
Commit By: tlyu
Revision: 22032
Changed Files:
U   branches/krb5-1-7/src/lib/krb5/krb/free_rtree.c
U   branches/krb5-1-7/src/lib/krb5/krb/init_ctx.c
U   branches/krb5-1-7/src/lib/krb5/krb/kfree.c
U   branches/krb5-1-7/src/lib/krb5/krb/preauth2.c
U   branches/krb5-1-7/src/lib/krb5/os/free_krbhs.c
U   branches/krb5-1-7/src/lib/krb5/os/promptusr.c




More information about the krb5-bugs mailing list