[krbdev.mit.edu #6618] Support optional creation of PID files for krb5kdc and kadmind

Russ Allbery <rra@stanford.edu> via RT rt-comment at krbdev.mit.edu
Thu Dec 31 16:30:44 EST 2009


[ghudson - Thu Dec 31 13:11:33 2009]:

> What I'd like to see, in both cases, is pid file setup moved into a
> static helper function.  This would reduce the number of duplicate
> cleanup sequences from two to one (both functions would benefit from
> flow control which avoids the need for duplicate cleanup sequences, but
> that's not your problem) and would also eliminate the need for inner
> variable declarations, which are discouraged by our coding practices.

Oh, sure, that's an easy fix and a good idea.  Attached is a new version
of the patch.



More information about the krb5-bugs mailing list