[krbdev.mit.edu #6124] ccache auxilliary functions

Ezra Peisach via RT rt-comment at krbdev.mit.edu
Tue Sep 23 06:45:27 EDT 2008


Looking at your changes I am concerned with the following:

a) Addition of functions to krb5.hin which are not added to the library
export list (cc_move, lock, etc).  If these are to be exported, please
change the exports list. If not - move them to the cc-int.h below...

b) Addition of library specific code to k5-int.h:  You have added the
k5_cc_mutex and support to the "global" k5-int.h.  I believe this code
will be localized to the krb5 library - and more specifically to the
ccache portion. Perhaps moving your changes to lib/krb5/ccache/cc-int.h
would be more appropriate.

Ezra



More information about the krb5-bugs mailing list