[krbdev.mit.edu #6041] WIN32 SOCKET != int in gss and rpc libs
Ken Raeburn via RT
rt-comment at krbdev.mit.edu
Wed Jul 23 16:37:05 EDT 2008
On Jul 23, 2008, at 13:25, Jeffrey Altman via RT wrote:
> sure although I don't understand why ignoring that return value should
> be treated specially.
It's not that there's anything special about close/closesocket, I just
don't want to make removing such casts a part of this otherwise fairly
specific change, in the absence of a specific coding style guideline
regarding ignored return values.
>> Why do you need to define INVALID_SOCKET in svc_udp.c?
>
> INVALID_SOCKET is a special value on Windows which is architecture
> dependent. Is INVALID_SOCKET defined somewhere else for Unix?
Yes, port-sockets.h already has a definition for the UNIX case.
The revised patch looks good, please check it in...
Ken
More information about the krb5-bugs
mailing list