[krbdev.mit.edu #5601] win-mac.h "leaks" defines

Jeffrey Altman via RT rt at krbdev.mit.edu
Wed Sep 19 00:54:49 EDT 2007


[raeburn - Mon Jul 30 16:20:26 2007]:

> I suggested a while back pruning win-mac.h and removing some macros,

I'm opposed to removal of #defines such as _USE_32BIT_TIME_T because
doing so would break applications that use the Kerberos API.  If we
define _USE_32BIT_TIME_T and the app does not, then they will pass in a
64-bit value when we are expecting a 32-bit value.

I would not be opposed to removal of #defines such as:

#define HAVE_NETINET_IN_H
#define MSDOS_FILESYSTEM
#define HAVE_STRING_H
#define HAVE_SRAND
#define HAVE_ERRNO
#define HAVE_STRDUP
#define HAVE_GETADDRINFO
#define HAVE_GETNAMEINFO
#define NO_USERID
#define NO_PASSWORD
#define HAVE_STRERROR
#define SYS_ERRLIST_DECLARED
#define HAS_VOID_TYPE
#define HAVE_STDARG_H
#define HAVE_SYS_TYPES_H
#define HAVE_STDLIB_H

provided that they continue to be defined when building the krb5
libraries.  There will need to be testing done to ensure that other MIT
applications which include the krb5 win-mac.h are not adversely affected.



More information about the krb5-bugs mailing list