[krbdev.mit.edu #5309]

william.fiveash@sun.com via RT rt-comment at krbdev.mit.edu
Tue Jan 9 22:48:02 EST 2007


The Synopsis should be:

Synopsis: bad logic in kadmin_unlock()

On Tue, Jan 09, 2007 at 08:19:22PM -0500, The RT System itself via RT wrote:
> >Confidential:	no 
> >Synopsis:	
> >Severity:	non-critical 
> >Priority:	low 
> >Category:	krb5-admin 
> >Class:		sw-bug 
> >Release:	krb5-1.6
> >Environment:
> 	
> System: SunOS alton 5.10 Generic_118833-18 sun4u sparc SUNW,Sun-Blade-1000
> Architecture: sun4
> 
> >Description:
> 	
> While porting code I noticed this in src/kadmin/cli/kadmin.c:
> 
> void kadmin_unlock(argc, argv)
>     int argc;
>     char *argv[];
> {
>     kadm5_ret_t retval;
> 
>     if (!locked)
>         return;
>     retval = kadm5_lock(handle);
>              !!!!!!!!!! should be kadm5_unlock() no?
>     if (retval) {
>         com_err("unlock", retval, "");
>         return;
>     }
>     locked = 0;
> }
> 
> >How-To-Repeat:
> 	
> >Fix:
> 	
> See Description.
> 
> _______________________________________________
> krb5-bugs mailing list
> krb5-bugs at mit.edu
> https://mailman.mit.edu/mailman/listinfo/krb5-bugs

-- 
Will Fiveash
Sun Microsystems Inc.
Austin, TX, USA (TZ=CST6CDT)




More information about the krb5-bugs mailing list