[krbdev.mit.edu #3610] memory leak of req_enctypes when using gss_set_allowable_enctypes

[The RT System itself via RT]

>From krb5-bugs-incoming-bounces at PCH.mit.edu  Wed Apr  5 15:10:04 2006
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP
	id PAA06626; Wed, 5 Apr 2006 15:10:04 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id k35J9VcL019236
	for <krb5-send-pr at krbdev.mit.edu>; Wed, 5 Apr 2006 15:09:31 -0400
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU
	[18.7.7.76])
	by pch.mit.edu (8.13.6/8.12.8) with ESMTP id k35J9UYK019213
	for <krb5-bugs-incoming at PCH.mit.edu>; Wed, 5 Apr 2006 15:09:30 -0400
Received: from citi.umich.edu (citi.umich.edu [141.211.133.111])
	by fort-point-station.mit.edu (8.13.6/8.9.2) with ESMTP id
	k35J9QEb009685
	for <krb5-bugs at mit.edu>; Wed, 5 Apr 2006 15:09:26 -0400 (EDT)
Received: from rock.citi.umich.edu (rock.citi.umich.edu [141.211.133.90])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by citi.umich.edu (Postfix) with ESMTP id 09E4E1BAF1
	for <krb5-bugs at mit.edu>; Wed,  5 Apr 2006 15:09:26 -0400 (EDT)
Received: (from kwc at localhost)
	by rock.citi.umich.edu (8.13.1/8.13.1/Submit) id k35J9PbJ030981;
	Wed, 5 Apr 2006 15:09:25 -0400
Date: Wed, 5 Apr 2006 15:09:25 -0400
Message-Id: <200604051909.k35J9PbJ030981 at rock.citi.umich.edu>
To: krb5-bugs at mit.edu
Subject: memory leak with gss_set_allowable_enctypes
From: kwc at citi.umich.edu
X-send-pr-version: 3.99
X-Spam-Score: -1.638
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: kwc at citi.umich.edu
Sender: krb5-bugs-incoming-bounces at PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces at PCH.mit.edu


>Submitter-Id:	net
>Originator:	Kevin Coffman (krb5)
>Organization:
	University of Michigan -- CITI
>Confidential:	no
>Synopsis:	memory leak of req_enctypes when using gss_set_allowable_enctypes
>Severity:	non-critical
>Priority:	medium
>Category:	krb5-libs
>Class:		sw-bug
>Release:	1.4.3
>Environment:
System: Linux rock.citi.umich.edu 2.6.16 #2 Tue Apr 4 11:59:44 EDT 2006 i686 i686 i386 GNU/Linux
Architecture: i686

>Description:
	The code for gss_set_allowable_enctypes() copies the list
	of requested enctypes to cred->req_enctypes.
	The release_cred routine was not changed to free this
	information.  (My bad.)

	Patch below fixes this.

>How-To-Repeat:
	Use gss_set_allowable_enctypes() and gss_release_cred().
>Fix:

--- rel_cred.c  2006-04-05 14:33:53.000000000 -0400
+++ /usr/local/src/krb5/krb5-1.4.2-keyring/src/lib/gssapi/krb5/rel_cred.c      2006-03-30 10:51:38.000000000 -0500
@@ -70,6 +70,8 @@ krb5_gss_release_cred(minor_status, cred
       code3 = 0;
    if (cred->princ)
       krb5_free_principal(context, cred->princ);
+   if (cred->req_enctypes)
+      xfree(cred->req_enctypes);
    xfree(cred);
    krb5_free_context(context);