[krbdev.mit.edu #2960] gssapi.h pollution

[Paul Kranenburg via RT]

I recently built and installed krb5 v1.4, which went smoothly, thanks 
for that. Then I noticed that some other software package would not build
any more. It took me a while to figure out this was due to the rather
anti-social contents at the top of the installed
<krp5path>/include/gssapi/gssapi.h header.

Here we find a bunch of non-gss related symbols intruding the 
consumer's namespace. In my case, it turned out to be HAVE_REGEX that
caused the kerberized application (samba 3.0.x) to gain functionality I
did not intend it to have.

I'm not sure why these configuration-related symbols were added to
gssapi.h (and, I notice, krb5.h as well), but I would suggest finding
another way than polluting the application's namespace in this manner to
achieve whatever problem it was intended to alleviate.  E.g. have the
library implementation pull in the required configuration defines
explicitly, or at least brace the offending section with something like
        #ifdef __GSSAPI_MIT_IMPLEMENTAION
        #endif


Best regards, -pk

----
Paul Kranenburg
Erasmus University Rotterdam