[krbdev.mit.edu #3308] kadmin.local is killed due to segmentation fault when principal name argument is missing.

[The RT System itself via RT]

>From krb5-bugs-incoming-bounces at PCH.mit.edu  Thu Dec 22 15:41:05 2005
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP
	id PAA01731; Thu, 22 Dec 2005 15:41:05 -0500 (EST)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
	by pch.mit.edu (8.12.8p2/8.12.8) with ESMTP id jBMKeOpx005092
	for <krb5-send-pr at krbdev.mit.edu>; Thu, 22 Dec 2005 15:40:24 -0500
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU
	[18.7.21.83])
	by pch.mit.edu (8.12.8p2/8.12.8) with ESMTP id jBKD8Ipx026084
	for <krb5-bugs-incoming at PCH.mit.edu>; Tue, 20 Dec 2005 08:08:32 -0500
Received: from sikandar.blr.novell.com (lan-202-144-95-244.maa.sify.net
	[202.144.95.244] (may be forged))
	by pacific-carrier-annex.mit.edu (8.12.4/8.9.2) with ESMTP id
	jBKD8LHv021334
	for <krb5-bugs at mit.edu>; Tue, 20 Dec 2005 08:08:26 -0500 (EST)
Received: by sikandar.blr.novell.com (Postfix, from userid 500)
	id 053FD8F40B; Tue, 20 Dec 2005 18:39:18 +0530 (IST)
To: krb5-bugs at mit.edu
Subject: kadmin.local is killed due to segmentation fault
From: srahul at novell.com
X-send-pr-version: 3.99
Message-Id: <20051220130918.053FD8F40B at sikandar.blr.novell.com>
Date: Tue, 20 Dec 2005 18:39:18 +0530 (IST)
X-Spam-Score: 5.094
X-Spam-Level: ***** (5.094)
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
X-Mailman-Approved-At: Wed, 21 Dec 2005 18:07:23 -0500
X-BeenThere: krb5-bugs-incoming at mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: srahul at novell.com
Sender: krb5-bugs-incoming-bounces at PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces at PCH.mit.edu


>Submitter-Id:	net
>Originator:	S Rahul
>Organization:
	
>Confidential:	no
>Synopsis:	kadmin.local is killed due to segmentation fault when principal name argument is missing.
>Severity:	non-critical
>Priority:	medium
>Category:	
>Class:		sw-bug
>Release:	1.4.3
>Environment:
	
System: Linux sikandar 2.6.11.4-21.9-default #1 Fri Aug 19 11:58:59 UTC 2005 i686 i686 i386 GNU/Linux
Architecture: i686

>Description:
	kadmin.local is killed due to segmentation fault when principal name
	argument is missing.
>How-To-Repeat:
bash$ kdb5_util create -s
Loading random data
Initializing database 'REALM1.db' for realm 'REALM1',
master key name 'K/M at REALM1'
You will be prompted for the database Master Password.
It is important that you NOT FORGET this password.
Enter KDC database master key: 
Re-enter KDC database master key to verify:
bash$ kadmin.local 
Authenticating as principal user1/admin at REALM1 with password.
kadmin.local:  cpw -pw pass
Segmentation fault (core dumped)
>Fix:
	Apply the following patch:
--- /tmp/krb5-1.4.3/src/kadmin/cli/kadmin.c     2005-12-20 17:55:43.000000000 +0530
+++ src/kadmin/cli/kadmin.c    2005-12-20 18:00:49.000000000 +0530
@@ -628,6 +628,10 @@
        }
        goto usage;
     }
+    if (*argv == NULL) {
+       fprintf(stderr, "change_password: missing principal name\n");
+       goto usage;
+    }
     retval = kadmin_parse_name(*argv, &princ);
     if (retval) {
        com_err("change_password", retval, "while parsing principal name");