[krbdev.mit.edu #2219] Potential memory leak in pre-authentication path

[The RT System itself via RT]

>From kwc at rock.citi.umich.edu  Fri Feb  6 16:40:39 2004
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by krbdev.mit.edu (8.9.3p2) with ESMTP
	id QAA24799; Fri, 6 Feb 2004 16:40:39 -0500 (EST)
Received: from citi.umich.edu (citi.umich.edu [141.211.133.111])
	by fort-point-station.mit.edu (8.12.4/8.9.2) with ESMTP id i16LecE9011676
	for <krb5-bugs at mit.edu>; Fri, 6 Feb 2004 16:40:39 -0500 (EST)
Received: from rock.citi.umich.edu (rock.citi.umich.edu [141.211.133.90])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by citi.umich.edu (Postfix) with ESMTP id 4156020B82
	for <krb5-bugs at mit.edu>; Fri,  6 Feb 2004 16:40:38 -0500 (EST)
Received: (from kwc at localhost)
	by rock.citi.umich.edu (8.12.8/8.12.8/Submit) id i16LeZer004517;
	Fri, 6 Feb 2004 16:40:35 -0500
Date: Fri, 6 Feb 2004 16:40:35 -0500
Message-Id: <200402062140.i16LeZer004517 at rock.citi.umich.edu>
To: krb5-bugs at mit.edu
From: kwc at citi.umich.edu
Reply-To: kwc at citi.umich.edu
Cc: 
X-send-pr-version: 3.99


>Submitter-Id:	net
>Originator:	Kevin Coffman
>Organization:
Kevin Coffman           Center for Information Technology Integration
----------------------  University of Michigan
Phone: (734) 763-0592   3106 Argus
mailto:kwc at umich.edu    535 West William Street
----------------------  Ann Arbor, MI, 48103-4943
http://www.citi.umich.edu/u/kwc/
>Confidential:	no
>Synopsis:	Potential memory leak in pre-authentication path
>Severity:	non-critical
>Priority:	medium
>Category:	krb5-kdc
>Class:		sw-bug
>Release:	krb5-1.3.2-beta2
>Environment:
	
System: Linux rock.citi.umich.edu 2.4.20-8 #1 Thu Mar 13 17:54:28 EST 2003 i686 i686 i386 GNU/Linux
Architecture: i686

>Description:
	While looking for a memory problem we were having, discovered what looks like
	a potential memory leak on the pre-authentication path.  The unparsed names
	are never freed.
>How-To-Repeat:
	
>Fix:
	


--- kdc_preauth.c.orig  2003-05-27 16:25:20.000000000 -0400
+++ kdc_preauth.c       2004-02-06 16:31:22.000000000 -0500
@@ -1531,6 +1531,8 @@
     if (sr) free(sr);
     if (psr) free(psr);
     if (esre) free(esre);
+    if (princ_psr) krb5_free_unparsed_name(context, princ_psr);
+    if (princ_req) krb5_free_unparsed_name(context, princ_req);
 
     return retval;
 }