[krbdev.mit.edu #2661] fake_getaddrinfo on address that doesn't reverse resolve causes crash

[Alexandra Ellwood via RT]

I tried to ssh to a machine whose name doesn't reverse resolve (meeroh.org) and ssh 
crashed.  The last ssh log messages are:

debug1: Local version string SSH-2.0-OpenSSH_3.6.1p1+CAN-2003-0693
debug3: Trying to reverse map address 204.188.130.39.
Bus error

The crash logs says we are to blame.  

Host Name:      elmekia-flame.mit.edu
Date/Time:      2004-08-09 11:46:40 -0400
OS Version:     10.3.4 (Build 7H63)
Report Version: 2

Command: ssh
Path:    /usr/bin/ssh
Version: ??? (???)
PID:     27202
Thread:  0

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_PROTECTION_FAILURE (0x0002) at 0x00000000

Thread 0 Crashed:
0   libSystem.B.dylib 	0x90006e40 strlen + 0x20
1   libSystem.B.dylib 	0x9000cf58 strdup + 0x18
2   edu.mit.Kerberos  	0x200a2784 fai_add_hosts_by_name + 0x234
3   edu.mit.Kerberos  	0x200a23d0 fake_getaddrinfo + 0x1b4
4   edu.mit.Kerberos  	0x200a1f54 krb5_sname_to_principal + 0xbc
5   edu.mit.Kerberos  	0x20076148 krb5_gss_import_name + 0x114
6   ssh               	0x000259d0 0x1000 + 0x249d0
7   ssh               	0x00025bac 0x1000 + 0x24bac
8   ssh               	0x00025150 0x1000 + 0x24150
9   ssh               	0x0000ee80 0x1000 + 0xde80
10  ssh               	0x0000d37c 0x1000 + 0xc37c
11  ssh               	0x00006ee8 0x1000 + 0x5ee8
12  ssh               	0x000058e0 0x1000 + 0x48e0
13  ssh               	0x00005754 0x1000 + 0x4754


This is the krb5 trunk (fake-addrinfo.h revision 1.49) and Panther (10.3.4). 
Assigned to Ken because I think he worked on the fake getaddrinfo stuff last.