[krbdev.mit.edu #1243] An error in source stops compiling (or Heaven help us if it doesn't)

[The RT System itself via RT]

>From Nikola.Milutinovic at ev.co.yu  Thu Nov  7 02:39:42 2002
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by krbdev.mit.edu (8.9.3) with ESMTP
	id CAA14973; Thu, 7 Nov 2002 02:39:42 -0500 (EST)
From: Nikola.Milutinovic at ev.co.yu
Received: from Firewall.ev.co.yu (gateway.ev.co.yu [194.247.214.130])
	by fort-point-station.mit.edu (8.9.2/8.9.2) with SMTP id CAA05868
	for <krb5-bugs at mit.edu>; Thu, 7 Nov 2002 02:39:38 -0500 (EST)
Received: by Firewall.ev.co.yu; (5.65v4.0/1.3/10May95) id AA22101; Sat, 7 Nov 1998 08:45:08 +0100
Received: from Legba.ev.co.yu (smmsp at localhost [127.0.0.1])
	by Legba.ev.co.yu (8.12.5/8.12.5) with ESMTP id gA77hBbC000796
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=FAIL)
	for <krb5-bugs at mit.edu>; Thu, 7 Nov 2002 08:43:12 +0100 (MET)
Received: (from root at localhost)
	by Legba.ev.co.yu (8.12.5/8.12.5/Submit) id gA77hBBb001143;
	Thu, 7 Nov 2002 08:43:11 +0100 (MET)
Date: Thu, 7 Nov 2002 08:43:11 +0100 (MET)
Message-Id: <200211070743.gA77hBBb001143 at Legba.ev.co.yu>
To: krb5-bugs at mit.edu
Reply-To: Nikola.Milutinovic at ev.co.yu
X-Send-Pr-Version: 3.99


>Submitter-Id:	net
>Originator:	Nikola Milutinovic
>Organization:	EPS Elektrovojvodina
	
>Confidential:	no
>Synopsis:	An error in source stops compiling (or Heaven help us if it doesn't)
>Severity:	serious
>Priority:	low
>Category:	krb5-build
>Class:		sw-bug
>Release:	krb5-1.2.6
>Environment:
	
System: OSF1 Legba.ev.co.yu V4.0 1229 alpha (Tru64 UNIX 4.0F)
Machine: DEC AlphaStation 200 4/233
>Description:
	Build fails in file "./src/krb524/sendmsg.c", at line 230, complaining that
	"addrlen" cannot be compared to "0". The offending line is:

	if ((local_addr != NULL) && (addrlen != NULL) && (addrlen > 0)) {

	Indeed, "addrlen" is "int *", which cannot be compared to integers.
	I gues the idea was to compare what addrlen points to and 0.
	
>How-To-Repeat:
	Just compile it with any ANSI C compiler, it should belch on that line.
	
>Fix:
	I have added "*" in front if "addrlen", so the line mow reads:

	if ((local_addr != NULL) && (addrlen != NULL) && (*addrlen > 0)) {