[krbdev.mit.edu #5609] NIM GUI picture does not track tray icon

[Public Submitter via RT]

> Index: credwnd.c
> ===================================================================
> --- credwnd.c   (revision 19739)
> +++ credwnd.c   (working copy)
> @@ -2248,6 +2248,11 @@
>      RECT t;
>      BOOL rie;
>      HBRUSH hbr;
> +    khm_handle  hc_cw           = NULL;
> +    khm_int32   bHideWatermarks = 0;
> +
> +    khc_open_space(NULL, L"CredWindow", KHM_PERM_READ, &hc_cw);
> +    if (hc_cw) {khc_read_int32(hc_cw, L"HideWatermarks",
> &bHideWatermarks);}
> 
>      switch(type) {
>      case CW_ER_BLANK:


A couple of comments:

1. You should call khc_close_space() to release the configuration space
handle you obtain using khc_open_space().

(see:
http://www.secure-endpoints.com/netidmgr/developer/group__kconf.html#g62d589d0a29fd534d9dfc1b7305f5efb
)

2. cw_erase_rect() is not the best place to check for this registry
setting.  This function is called many times during a screen refresh to
erase portions of the credentials display area.  It would be better if
this registry setting is read somewhere else (eg: in cw_load_view())
instead.