krb5 1.11.3: variadic-macros issue with NetBSD 5.1

[Benjamin Kaduk]

On Sun, 1 Sep 2013, Julien ÉLIE wrote:

> Hi Benjamin,
>
>>> ../../../include/k5-trace.h:93:20: error: anonymous variadic macros
>>> were introduced in C99 [-Werror=variadic-macros]
>>> #define TRACE(ctx, ...)                                        \
>>>                    ^
>>>
>>> Would it be possible to fix the issue for the next krb5 release?
>>> (Maybe by not using the gcc "-Werror=variadic-macros" flag?)
>>
>> Commit d211001ba17fddfb952beb00118dc5c7e598355e on git master has
>> resolved the issue (I saw it on FreeBSD as well, though only as a
>> warning).  It does not appear to be marked for pullup to the 1.11
>> branch, though; I'll look at whether that's reasonable to do.
>
> OK, many thanks for having answered.
> If the patch is not marked for the 1.11 branch, I hope it will be
> shipped with the 1.12.0 release.  If that is the case, it is fine for
> me, I shall wait for it.  Do not worry, and thanks again.

It will definitely be in 1.12, and it should be in 1.11.4 as well.

Thanks for the report!

-Ben Kaduk