Fix for memory leak in krb5 1.3.5

[Jeffrey Altman]

Jeremy:

You don't want my attention.  If you have patches or bugs you would like 
to submit the proper place to do so is by sending mail to 
krb5-bugs at mit.edu.

Jeffrey Altman


Jeremy Allison wrote:

> Jeffrey Altman wrote:
> 
>> I'm not sure why it was not pulled into the 1.3 tree but this
>> problem does not exist in the cvs-head.
> 
> 
> Hmmm. Now I have your attention, is there any chance of the following
> patch being accepted for the next release ? I compile Samba with maximum
> warnings and the use of
> 
> void fn()
> 
> instead of the standard C method of :
> 
> void fn(void)
> 
> always causes nasty warnings on every file :-(.
> 
> Jeremy.
> 
> -----------------------------------------------------------------------
> --- /usr/kerberos-1.3.5/include/krb5.h.orig     2004-11-04 
> 16:45:35.000000000 -0800
> +++ /usr/kerberos-1.3.5/include/krb5.h  2004-11-04 16:47:39.000000000 -0800
> @@ -2860,7 +2860,7 @@
> 
>  #if !defined(_WIN32)
>  /* for compatibility with older versions... */
> -extern void initialize_krb5_error_table () /*@modifies internalState@*/;
> +extern void initialize_krb5_error_table (void) /*@modifies 
> internalState@*/;
>  #else
>  #define initialize_krb5_error_table()
>  #endif
> @@ -2911,7 +2911,7 @@
> 
>  #if !defined(_WIN32)
>  /* for compatibility with older versions... */
> -extern void initialize_kdb5_error_table () /*@modifies internalState@*/;
> +extern void initialize_kdb5_error_table (void) /*@modifies 
> internalState@*/;
>  #else
>  #define initialize_kdb5_error_table()
>  #endif
> @@ -2990,7 +2990,7 @@
> 
>  #if !defined(_WIN32)
>  /* for compatibility with older versions... */
> -extern void initialize_kv5m_error_table () /*@modifies internalState@*/;
> +extern void initialize_kv5m_error_table (void) /*@modifies 
> internalState@*/;
>  #else
>  #define initialize_kv5m_error_table()
>  #endif
> @@ -3021,7 +3021,7 @@
> 
>  #if !defined(_WIN32)
>  /* for compatibility with older versions... */
> -extern void initialize_k524_error_table () /*@modifies internalState@*/;
> +extern void initialize_k524_error_table (void) /*@modifies 
> internalState@*/;
>  #else
>  #define initialize_k524_error_table()
>  #endif
> @@ -3056,7 +3056,7 @@
> 
>  #if !defined(_WIN32)
>  /* for compatibility with older versions... */
> -extern void initialize_asn1_error_table () /*@modifies internalState@*/;
> +extern void initialize_asn1_error_table (void) /*@modifies 
> internalState@*/;
>  #else
>  #define initialize_asn1_error_table()
>  #endif
> -----------------------------------------------------------------------

-- 
-----------------
This e-mail account is not read on a regular basis.
Please send private responses to jaltman at mit dot edu