krb5 commit: Remove redundant check in acquire_cred_from()

ghudson at mit.edu ghudson at mit.edu
Wed Jan 8 17:26:17 EST 2025


https://github.com/krb5/krb5/commit/861a3aa3627472f784f580063808c3febe2a0061
commit 861a3aa3627472f784f580063808c3febe2a0061
Author: Julien Rische <jrische at redhat.com>
Date:   Wed Jan 8 12:36:07 2025 +0100

    Remove redundant check in acquire_cred_from()
    
    When processing KRB5_CS_PASSWORD_URN, only check for null desired_name
    once.
    
    [ghudson at mit.edu: edited commit message]

 src/lib/gssapi/krb5/acquire_cred.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 006eba114..d49ad07ea 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -1283,8 +1283,8 @@ acquire_cred_from(OM_uint32 *minor_status, const gss_name_t desired_name,
             ret = GSS_S_BAD_NAME;
             goto out;
         }
-        if (cred_usage == GSS_C_ACCEPT || desired_name == GSS_C_NO_NAME ||
-            ccache != NULL || client_keytab != NULL) {
+        if (cred_usage == GSS_C_ACCEPT || ccache != NULL ||
+            client_keytab != NULL) {
             *minor_status = (OM_uint32)G_BAD_USAGE;
             ret = GSS_S_FAILURE;
             goto out;


More information about the cvs-krb5 mailing list