krb5 commit: Reunite xdrproc_t with its comment in xdr.h

ghudson at mit.edu ghudson at mit.edu
Mon Aug 11 15:43:06 EDT 2025


https://github.com/krb5/krb5/commit/f458ddf03332abface47d90d1389b45540805b6f
commit f458ddf03332abface47d90d1389b45540805b6f
Author: J. Neuschäfer <j.ne at posteo.net>
Date:   Fri Aug 1 19:29:23 2025 +0000

    Reunite xdrproc_t with its comment in xdr.h
    
    Commit 4b9d7f7c107f01a61600fddcd8cde3812d0366a2 moved the declaration
    of xdrproc_t later in the file so that it could refer to XDR, but did
    not move the preceding comment.  Move the comment and edit it for
    accuracy.
    
    [ghudson at mit.edu: expanded commit message; edited comment]

 src/include/gssrpc/xdr.h | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/src/include/gssrpc/xdr.h b/src/include/gssrpc/xdr.h
index 4e5c29bdc..57cd577e6 100644
--- a/src/include/gssrpc/xdr.h
+++ b/src/include/gssrpc/xdr.h
@@ -91,18 +91,6 @@ enum xdr_op {
 #define RNDUP(x)  ((((x) + BYTES_PER_XDR_UNIT - 1) / BYTES_PER_XDR_UNIT) \
 		    * BYTES_PER_XDR_UNIT)
 
-/*
- * A xdrproc_t exists for each data type which is to be encoded or decoded.
- *
- * The second argument to the xdrproc_t is a pointer to an opaque pointer.
- * The opaque pointer generally points to a structure of the data type
- * to be decoded.  If this pointer is 0, then the type routines should
- * allocate dynamic storage of the appropriate size and return it.
- * bool_t	(*xdrproc_t)(XDR *, caddr_t *);
- *
- * XXX can't actually prototype it, because some take three args!!!
- */
-
 /*
  * The XDR handle.
  * Contains operation which is being applied to the stream,
@@ -142,6 +130,10 @@ typedef struct XDR {
 	int		x_handy;	/* extra private word */
 } XDR;
 
+/*
+ * A xdrproc_t exists for each data type which is to be encoded or decoded.
+ * The second argument points to an object of the data type.
+ */
 typedef	bool_t (*xdrproc_t)(XDR *, void *);
 
 /*


More information about the cvs-krb5 mailing list