krb5 commit: Free verto context later in KDC cleanup

ghudson at mit.edu ghudson at mit.edu
Wed Jun 8 20:45:20 EDT 2022


https://github.com/krb5/krb5/commit/8dcace04945723cd6a3c8ea2c1ba467c22eb6584
commit 8dcace04945723cd6a3c8ea2c1ba467c22eb6584
Author: Greg Hudson <ghudson at mit.edu>
Date:   Fri Jun 3 14:38:45 2022 -0400

    Free verto context later in KDC cleanup
    
    The KDC supplies the verto context to kdcpreauth modules via the loop
    method (added in commit 83b4ecd20e50ad330cd761977d5dadefe30a785b).
    This context should remain valid until kdcpreauth modules are
    unloaded, as modules might refer to it during cleanup.  In particular,
    the OTP module references the verto context when freeing the RADIUS
    client object (commit e89abc2d4ea1fea1ec28d470f297514b828e4842), which
    can cause a memory error during KDC shutdown without this change.
    
    ticket: 9064 (new)
    tags: pullup
    target_version: 1.20-next
    target_version: 1.19-next

 src/kdc/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kdc/main.c b/src/kdc/main.c
index be6e361b8..bfdfef5c4 100644
--- a/src/kdc/main.c
+++ b/src/kdc/main.c
@@ -1037,7 +1037,6 @@ int main(int argc, char **argv)
     kau_kdc_start(kcontext, TRUE);
 
     verto_run(ctx);
-    loop_free(ctx);
     kau_kdc_stop(kcontext, TRUE);
     krb5_klog_syslog(LOG_INFO, _("shutting down"));
     unload_preauth_plugins(kcontext);
@@ -1051,6 +1050,7 @@ int main(int argc, char **argv)
 #ifndef NOCACHE
     kdc_free_lookaside(kcontext);
 #endif
+    loop_free(ctx);
     krb5_free_context(kcontext);
     return errout;
 }


More information about the cvs-krb5 mailing list