krb5 commit: Constify name field in four plugin vtables

Greg Hudson ghudson at mit.edu
Fri Sep 10 12:22:30 EDT 2021


https://github.com/krb5/krb5/commit/789a4d315f321ef6ac085bf227c4ad1a34367086
commit 789a4d315f321ef6ac085bf227c4ad1a34367086
Author: Pavel Březina <pbrezina at redhat.com>
Date:   Wed Sep 8 15:44:30 2021 +0200

    Constify name field in four plugin vtables
    
    For consistency with the other plugin vtables, declare the name field
    as const char * in the audit, authdata, clpreauth, and kdcpreauth
    pluggable interface headers.
    
    [ghudson at mit.edu: rewrote commit message]
    
    ticket: 9028 (new)

 src/include/krb5/audit_plugin.h      |    2 +-
 src/include/krb5/authdata_plugin.h   |    2 +-
 src/include/krb5/clpreauth_plugin.h  |    2 +-
 src/include/krb5/kdcpreauth_plugin.h |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/include/krb5/audit_plugin.h b/src/include/krb5/audit_plugin.h
index 64dda75..3315d77 100644
--- a/src/include/krb5/audit_plugin.h
+++ b/src/include/krb5/audit_plugin.h
@@ -255,7 +255,7 @@ typedef krb5_error_code
 /* vtable declaration */
 typedef struct krb5_audit_vtable_st {
     /* Mandatory: name of module. */
-    char                   *name;
+    const char             *name;
     krb5_audit_open_fn      open;
     krb5_audit_close_fn     close;
     krb5_audit_kdc_start_fn kdc_start;
diff --git a/src/include/krb5/authdata_plugin.h b/src/include/krb5/authdata_plugin.h
index 5bb95fa..d59a8eb 100644
--- a/src/include/krb5/authdata_plugin.h
+++ b/src/include/krb5/authdata_plugin.h
@@ -191,7 +191,7 @@ typedef krb5_error_code
                              void *dst_request_context);
 
 typedef struct krb5plugin_authdata_client_ftable_v0 {
-    char *name;
+    const char *name;
     krb5_authdatatype *ad_type_list;
     authdata_client_plugin_init_proc init;
     authdata_client_plugin_fini_proc fini;
diff --git a/src/include/krb5/clpreauth_plugin.h b/src/include/krb5/clpreauth_plugin.h
index 22a5e9b..8832a68 100644
--- a/src/include/krb5/clpreauth_plugin.h
+++ b/src/include/krb5/clpreauth_plugin.h
@@ -299,7 +299,7 @@ typedef krb5_error_code
 
 typedef struct krb5_clpreauth_vtable_st {
     /* Mandatory: name of module. */
-    char *name;
+    const char *name;
 
     /* Mandatory: pointer to zero-terminated list of pa_types which this module
      * can provide services for. */
diff --git a/src/include/krb5/kdcpreauth_plugin.h b/src/include/krb5/kdcpreauth_plugin.h
index 3a47542..b0daae1 100644
--- a/src/include/krb5/kdcpreauth_plugin.h
+++ b/src/include/krb5/kdcpreauth_plugin.h
@@ -380,7 +380,7 @@ typedef krb5_error_code
 
 typedef struct krb5_kdcpreauth_vtable_st {
     /* Mandatory: name of module. */
-    char *name;
+    const char *name;
 
     /* Mandatory: pointer to zero-terminated list of pa_types which this module
      * can provide services for. */


More information about the cvs-krb5 mailing list