krb5 commit: Omit KDC indicator check for S4U2Self requests

Greg Hudson ghudson at mit.edu
Thu May 7 12:43:24 EDT 2020


https://github.com/krb5/krb5/commit/183631fbf72351c2d5fc7d60b2d9fc4d09fe7465
commit 183631fbf72351c2d5fc7d60b2d9fc4d09fe7465
Author: Greg Hudson <ghudson at mit.edu>
Date:   Wed May 6 16:03:13 2020 -0400

    Omit KDC indicator check for S4U2Self requests
    
    As there was no initial ticket exchange from the client for an
    S4U2Self request, the auth indicator check is inapplicable (and would
    always fail if any auth indicators are required).
    
    ticket: 8902 (new)

 src/kdc/do_tgs_req.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index 241f34e..463a9c0 100644
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -392,8 +392,8 @@ process_tgs_req(krb5_kdc_req *request, krb5_data *pkt,
     }
     authtime = subject_tkt->times.authtime;
 
-    /* Extract auth indicators from the subject ticket, except for S4U2Self
-     * requests (where the client didn't authenticate). */
+    /* Extract and check auth indicators from the subject ticket, except for
+     * S4U2Self requests (where the client didn't authenticate). */
     if (s4u_x509_user == NULL) {
         errcode = get_auth_indicators(kdc_context, subject_tkt, local_tgt,
                                       &local_tgt_key, &auth_indicators);
@@ -401,12 +401,12 @@ process_tgs_req(krb5_kdc_req *request, krb5_data *pkt,
             status = "GET_AUTH_INDICATORS";
             goto cleanup;
         }
-    }
 
-    errcode = check_indicators(kdc_context, server, auth_indicators);
-    if (errcode) {
-        status = "HIGHER_AUTHENTICATION_REQUIRED";
-        goto cleanup;
+        errcode = check_indicators(kdc_context, server, auth_indicators);
+        if (errcode) {
+            status = "HIGHER_AUTHENTICATION_REQUIRED";
+            goto cleanup;
+        }
     }
 
     if (is_referral)


More information about the cvs-krb5 mailing list