krb5 commit: Fix error return case in serialization code

Greg Hudson ghudson at mit.edu
Sun Jan 5 01:54:30 EST 2020


https://github.com/krb5/krb5/commit/82d7ffb07c81aefeabf67c7c066070efbc34400b
commit 82d7ffb07c81aefeabf67c7c066070efbc34400b
Author: Greg Hudson <ghudson at mit.edu>
Date:   Mon Dec 9 11:33:57 2019 -0500

    Fix error return case in serialization code
    
    One of the changes in commit 81e47875e3de0e52fbb11d61ef30a9406497af73
    unintentionally caused the return value of profile_ser_externalize()
    to be ignored.

 src/lib/krb5/krb/ser_ctx.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/krb/ser_ctx.c b/src/lib/krb5/krb/ser_ctx.c
index 80cd056..9d5f9de 100644
--- a/src/lib/krb5/krb/ser_ctx.c
+++ b/src/lib/krb5/krb/ser_ctx.c
@@ -204,8 +204,11 @@ k5_externalize_context(krb5_context context,
         return (kret);
 
     /* Finally, handle profile, if appropriate */
-    if (context->profile != NULL)
+    if (context->profile != NULL) {
         kret = profile_ser_externalize(NULL, context->profile, &bp, &remain);
+        if (kret)
+            return (kret);
+    }
 
     /*
      * If we were successful, write trailer then update the pointer and


More information about the cvs-krb5 mailing list