krb5 commit [krb5-1.17]: Fix KCM client time offset propagation

Greg Hudson ghudson at mit.edu
Mon Dec 9 18:23:53 EST 2019


https://github.com/krb5/krb5/commit/3a32b06e10088ce6ef862cf454fa3e8f8b32db7d
commit 3a32b06e10088ce6ef862cf454fa3e8f8b32db7d
Author: Robbie Harwood <rharwood at redhat.com>
Date:   Wed Aug 14 13:52:27 2019 -0400

    Fix KCM client time offset propagation
    
    An inverted status check in get_kdc_offset() would cause querying the
    offset time from the ccache to always fail (silently) on KCM.  Fix the
    status check so that KCM can properly handle desync.
    
    (cherry picked from commit 323abb6d1ebe5469d6c2167c29aa5d696d099b90)
    
    ticket: 8826
    version_fixed: 1.17.1

 src/lib/krb5/ccache/cc_kcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/ccache/cc_kcm.c b/src/lib/krb5/ccache/cc_kcm.c
index 092ab7d..fe93ca3 100644
--- a/src/lib/krb5/ccache/cc_kcm.c
+++ b/src/lib/krb5/ccache/cc_kcm.c
@@ -583,7 +583,7 @@ get_kdc_offset(krb5_context context, krb5_ccache cache)
     if (cache_call(context, cache, &req, FALSE) != 0)
         goto cleanup;
     time_offset = k5_input_get_uint32_be(&req.reply);
-    if (!req.reply.status)
+    if (req.reply.status)
         goto cleanup;
     context->os_context.time_offset = time_offset;
     context->os_context.usec_offset = 0;


More information about the cvs-krb5 mailing list