krb5 commit: Fix potential close(-1) in cc_file.c

Greg Hudson ghudson at mit.edu
Thu Apr 18 16:53:58 EDT 2019


https://github.com/krb5/krb5/commit/5ccfbaf2f0c8871d2f0ea87ad4b21cc33392ca2c
commit 5ccfbaf2f0c8871d2f0ea87ad4b21cc33392ca2c
Author: Robbie Harwood <rharwood at redhat.com>
Date:   Thu Apr 18 13:39:37 2019 -0400

    Fix potential close(-1) in cc_file.c
    
    As part of error handling in d3b39a8bac6206b5ea78b0bf6a2958c1df0b0dd5,
    an error path in delete_cred() may result in close(-1).  While this
    shouldn't be a prolblem in practice (just returning EBADF), it does
    upset Coverity.
    
    ticket: 8792

 src/lib/krb5/ccache/cc_file.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/ccache/cc_file.c b/src/lib/krb5/ccache/cc_file.c
index f0f1409..e78ac3a 100644
--- a/src/lib/krb5/ccache/cc_file.c
+++ b/src/lib/krb5/ccache/cc_file.c
@@ -1122,7 +1122,8 @@ delete_cred(krb5_context context, krb5_ccache cache, krb5_cc_cursor *cursor,
     }
 
 cleanup:
-    close(fd);
+    if (fd >= 0)
+        close(fd);
     zapfree(on_disk, expected.len);
     k5_buf_free(&expected);
     k5_buf_free(&overwrite);


More information about the cvs-krb5 mailing list