krb5 commit: Fix getdate.y compatability with POSIX yacc

Greg Hudson ghudson at mit.edu
Wed Sep 26 18:28:27 EDT 2018


https://github.com/krb5/krb5/commit/4e126e2cae8c3a63f252776ac6efc93a2d8e0d5c
commit 4e126e2cae8c3a63f252776ac6efc93a2d8e0d5c
Author: Robbie Harwood <rharwood at redhat.com>
Date:   Tue Sep 25 13:20:55 2018 -0400

    Fix getdate.y compatability with POSIX yacc
    
    Commit 28fd0a934cdc7b3b42ce213c6d334d4edf1ab591 muted a warning from
    bison about shift/reduce conflicts in the grammer.  However, the
    extension for suppressing the warning is bison-only.  Revert that
    portion of the change and live with the warning rather than adding
    additional conditionalization.  Reported by Michael Osipov.

 src/kadmin/cli/getdate.y |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/kadmin/cli/getdate.y b/src/kadmin/cli/getdate.y
index cb039ac..4f0fac2 100644
--- a/src/kadmin/cli/getdate.y
+++ b/src/kadmin/cli/getdate.y
@@ -176,8 +176,9 @@ static time_t	yyRelSeconds;
 
 %}
 
-/* Mute shift/reduce warning as per header comment. */
-%expect 4
+/* This would mute the shift/reduce warnings as per header comment; however,
+ * it relies on bison extensions. */
+/* %expect 4 */
 
 %union {
     time_t		Number;


More information about the cvs-krb5 mailing list