krb5 commit: Always set appdefault_get() output argument

Greg Hudson ghudson at mit.edu
Tue Jan 30 13:50:15 EST 2018


https://github.com/krb5/krb5/commit/364c608911af2f227695bb527d4e42f091ee8bd3
commit 364c608911af2f227695bb527d4e42f091ee8bd3
Author: Nehal J Wani <nehaljw.kkd1 at gmail.com>
Date:   Sun Jan 28 03:02:57 2018 -0500

    Always set appdefault_get() output argument
    
    gcc 7 cannot determine that appdefault_get() always sets *ret_value
    when it returns zero, so issues a "may be used uninitialized" warning
    in its caller.  Set *ret_value at the beginning of the function body
    in accordance with current practices.
    
    [ghudson at mit.edu: clarified commit message]
    
    ticket: 8639 (new)
    tags: pullup
    target_version: 1.16-next
    target_version: 1.15-next

 src/lib/krb5/krb/appdefault.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/lib/krb5/krb/appdefault.c b/src/lib/krb5/krb/appdefault.c
index 73fd260..3f7dc23 100644
--- a/src/lib/krb5/krb/appdefault.c
+++ b/src/lib/krb5/krb/appdefault.c
@@ -44,6 +44,8 @@ appdefault_get(krb5_context context, const char *appname, const krb5_data *realm
     krb5_error_code retval;
     const char * realmstr =  realm?realm->data:NULL;
 
+    *ret_value = NULL;
+
     if (!context || (context->magic != KV5M_CONTEXT))
         return KV5M_CONTEXT;
 


More information about the cvs-krb5 mailing list