krb5 commit: Fix double-close in ksu get_authorized_princ_names
Greg Hudson
ghudson at mit.edu
Wed Dec 19 13:12:45 EST 2018
https://github.com/krb5/krb5/commit/0b8c6f3e1e8e561aa56a7d4e2171320119991dae
commit 0b8c6f3e1e8e561aa56a7d4e2171320119991dae
Author: Robbie Harwood <rharwood at redhat.com>
Date: Tue Dec 18 15:18:13 2018 -0500
Fix double-close in ksu get_authorized_princ_names
If list_union() fails due to an allocation failure, then close_time()
will attempt to fclose users_fp and login_fp a second time.
This bug was originally introduced in commit
be95b52c2d0c21b1fe92f9f90166fc2fa8eecc95, and has been present in
every krb5 release since 1.1.
ticket: 8768 (new)
tags: pullup
target_version: 1.17
target_version: 1.16-next
target_version: 1.15-next
src/clients/ksu/heuristic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/clients/ksu/heuristic.c b/src/clients/ksu/heuristic.c
index 0d055e4..3eb28ab 100644
--- a/src/clients/ksu/heuristic.c
+++ b/src/clients/ksu/heuristic.c
@@ -266,7 +266,6 @@ get_authorized_princ_names(luser, cmd, princ_list)
retval = list_union(k5login_list, k5users_filt_list, &combined_list);
if (retval){
- close_time(k5users_flag,users_fp, k5login_flag,login_fp);
return retval;
}
*princ_list = combined_list;
More information about the cvs-krb5
mailing list