krb5 commit [krb5-1.14]: Fix build with -O3 on ppc64el

Tom Yu tlyu at mit.edu
Fri Sep 9 17:07:55 EDT 2016


https://github.com/krb5/krb5/commit/ad3d9a208b97754317403e63a28da4c1b4ca6b63
commit ad3d9a208b97754317403e63a28da4c1b4ca6b63
Author: Ben Kaduk <kaduk at mit.edu>
Date:   Wed Aug 10 23:25:47 2016 -0500

    Fix build with -O3 on ppc64el
    
    Ubuntu runs ppc64el builds with -O3, which elicited a few warnings
    from gcc that were not generated elsewhere, as documented at
    https://bugs.launchpad.net/ubuntu/+source/krb5/+bug/1592841 .
    
    Initialize the output variable at the top of a couple of helper functions
    to silence the uninitialized-variable warnings.
    
    (cherry picked from commit 7db89952d8d4f806ac8b4908f898ac651df11643)
    
    ticket: 8475
    version_fixed: 1.14.4

 src/lib/krb5/os/sendto_kdc.c |    2 ++
 src/tests/asn.1/trval.c      |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c
index 5d9fbc2..6231de2 100644
--- a/src/lib/krb5/os/sendto_kdc.c
+++ b/src/lib/krb5/os/sendto_kdc.c
@@ -173,6 +173,8 @@ get_curtime_ms(time_ms *time_out)
 {
     struct timeval tv;
 
+    *time_out = 0;
+
     if (gettimeofday(&tv, 0))
         return errno;
     *time_out = (time_ms)tv.tv_sec * 1000 + tv.tv_usec / 1000;
diff --git a/src/tests/asn.1/trval.c b/src/tests/asn.1/trval.c
index e924fd8..c14bcde 100644
--- a/src/tests/asn.1/trval.c
+++ b/src/tests/asn.1/trval.c
@@ -180,6 +180,7 @@ int trval2(fp, enc, len, lev, rlen)
     int rlen_ext = 0;
 
     r = OK;
+    *rlen = -1;
 
     if (len < 2) {
         fprintf(fp, "missing id and length octets (%d)\n", len);


More information about the cvs-krb5 mailing list