krb5 commit [krb5-1.13]: Fix leak in ulog_replay()

Tom Yu tlyu at mit.edu
Fri Sep 9 14:48:11 EDT 2016


https://github.com/krb5/krb5/commit/d3b8c7cab44001d6a7aaa50d747eed019361d8d2
commit d3b8c7cab44001d6a7aaa50d747eed019361d8d2
Author: Greg Hudson <ghudson at mit.edu>
Date:   Tue Jun 28 18:01:55 2016 -0400

    Fix leak in ulog_replay()
    
    ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
    should not also do so.
    
    (cherry picked from commit 2908839fcae0a12c56514d551ed1f19a7797cddb)
    
    ticket: 8441
    version_fixed: 1.13.7

 src/lib/kdb/kdb_log.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index faca467..3954014 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -387,10 +387,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
             if (retval)
                 goto cleanup;
         } else {
-            entry = k5alloc(sizeof(krb5_db_entry), &retval);
-            if (entry == NULL)
-                goto cleanup;
-
             retval = ulog_conv_2dbentry(context, &entry, upd);
             if (retval)
                 goto cleanup;


More information about the cvs-krb5 mailing list