krb5 commit: Fix leak in ulog_replay()
Greg Hudson
ghudson at mit.edu
Wed Aug 10 13:51:39 EDT 2016
https://github.com/krb5/krb5/commit/2908839fcae0a12c56514d551ed1f19a7797cddb
commit 2908839fcae0a12c56514d551ed1f19a7797cddb
Author: Greg Hudson <ghudson at mit.edu>
Date: Tue Jun 28 18:01:55 2016 -0400
Fix leak in ulog_replay()
ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
should not also do so.
ticket: 8441 (new)
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
src/lib/kdb/kdb_log.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index d377a20..99cda59 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -414,10 +414,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
if (retval)
goto cleanup;
} else {
- entry = k5alloc(sizeof(krb5_db_entry), &retval);
- if (entry == NULL)
- goto cleanup;
-
retval = ulog_conv_2dbentry(context, &entry, upd);
if (retval)
goto cleanup;
More information about the cvs-krb5
mailing list