krb5 commit: Fix leak in k5_free_cammac()

Greg Hudson ghudson at mit.edu
Wed Aug 10 13:51:36 EDT 2016


https://github.com/krb5/krb5/commit/d9d6e7e9aa619d5bd35fa6e4468683ee7ddb5e5d
commit d9d6e7e9aa619d5bd35fa6e4468683ee7ddb5e5d
Author: Greg Hudson <ghudson at mit.edu>
Date:   Mon Jun 27 19:38:36 2016 -0400

    Fix leak in k5_free_cammac()
    
    free_vmac(), a helper function used by k5_free_cammac(), must free its
    val pointer as well as the contents; otherwise the krb5_verifier_mac
    container is leaked.
    
    ticket: 8438 (new)
    target_version: 1.14-next
    tags: pullup

 src/lib/krb5/krb/kfree.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/lib/krb5/krb/kfree.c b/src/lib/krb5/krb/kfree.c
index f857522..a631807 100644
--- a/src/lib/krb5/krb/kfree.c
+++ b/src/lib/krb5/krb/kfree.c
@@ -863,6 +863,7 @@ free_vmac(krb5_context context, krb5_verifier_mac *val)
         return;
     krb5_free_principal(context, val->princ);
     krb5_free_checksum_contents(context, &val->checksum);
+    free(val);
 }
 
 void


More information about the cvs-krb5 mailing list