krb5 commit: Log invalid restrictions strings

Greg Hudson ghudson at mit.edu
Sat Mar 14 00:19:15 EDT 2015


https://github.com/krb5/krb5/commit/e9eaafeab12b2b62595f4dff2fca3345b2d95b4a
commit e9eaafeab12b2b62595f4dff2fca3345b2d95b4a
Author: Greg Hudson <ghudson at mit.edu>
Date:   Fri Mar 13 13:30:49 2015 -0400

    Log invalid restrictions strings
    
    In kadm5int_acl_parse_restrictions(), output a log message if we break
    out of the parsing loop with an error.  The current structure of the
    loop makes it difficult to pinpoint the bad restrictions field, so
    just output the whole string.
    
    ticket: 8155
    target_version: 1.13.2
    tags: pullup

 src/lib/kadm5/srv/server_acl.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/lib/kadm5/srv/server_acl.c b/src/lib/kadm5/srv/server_acl.c
index 86e1367..64f7385 100644
--- a/src/lib/kadm5/srv/server_acl.c
+++ b/src/lib/kadm5/srv/server_acl.c
@@ -349,6 +349,10 @@ kadm5int_acl_parse_restrictions(s, rpp)
                     }
                 }
             }
+            if (code) {
+                krb5_klog_syslog(LOG_ERR, _("%s: invalid restrictions: %s"),
+                                 acl_acl_file, s);
+            }
         }
     }
     if (sp)


More information about the cvs-krb5 mailing list