krb5 commit [krb5-1.13]: Fix bindresvport_sa port byte swap bug
Tom Yu
tlyu at mit.edu
Wed Jun 24 18:24:16 EDT 2015
https://github.com/krb5/krb5/commit/98cf93e21747cc6641475410ccc9f1ba3e17c162
commit 98cf93e21747cc6641475410ccc9f1ba3e17c162
Author: Greg Hudson <ghudson at mit.edu>
Date: Tue May 19 10:38:51 2015 -0400
Fix bindresvport_sa port byte swap bug
The sa_setport() helper handles conversion to network byte order, so
bindresvport_sa() should not itself call htons() on the port argument.
(This bug was introduced in commit
0d04b60d159ab83b943e43802b1449a3b074bc83 when adding
bindresvport_sa(). It was my fault, not Andreas Schneider's.)
(cherry picked from commit 5c6d218e385755766ff427b3e707510f0ce175c5)
ticket: 8197
version_fixed: 1.13.3
status: resolved
src/lib/rpc/bindresvport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/rpc/bindresvport.c b/src/lib/rpc/bindresvport.c
index ccc4d73..a421dd8 100644
--- a/src/lib/rpc/bindresvport.c
+++ b/src/lib/rpc/bindresvport.c
@@ -76,7 +76,7 @@ bindresvport_sa(int sd, struct sockaddr *sa)
res = -1;
errno = EADDRINUSE;
for (i = 0; i < NPORTS && res < 0 && errno == EADDRINUSE; i++) {
- sa_setport(sa, htons(port++));
+ sa_setport(sa, port++);
if (port > ENDPORT) {
port = STARTPORT;
}
More information about the cvs-krb5
mailing list