krb5 commit [krb5-1.13]: Put focus on password field when principal is set

Tom Yu tlyu at mit.edu
Wed Jun 24 17:59:39 EDT 2015


https://github.com/krb5/krb5/commit/b1ec8b1306f31d92235ec795d01801f11a7b38fe
commit b1ec8b1306f31d92235ec795d01801f11a7b38fe
Author: Ben Kaduk <kaduk at mit.edu>
Date:   Mon Jun 22 19:11:28 2015 -0400

    Put focus on password field when principal is set
    
    In the Leash "Get Ticket" window, under some user-customized
    configurations, the principal field can be pre-populated.  In this case,
    it makes sense for the default focus to be on the password field,
    since most users will only be using a single principal and should
    go directly to typing their password.
    
    The focus was already set to the password field in the case when
    the principal was not modifiable (such as when the "Get Ticket" dialog
    was opened by an application requesting a specific ticket).
    
    (cherry picked from commit 50b3bba748084c99a339bd526ad47ecfccc09472)
    
    ticket: 8032
    version_fixed: 1.13.3
    status: resolved

 src/windows/leashdll/lsh_pwd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/windows/leashdll/lsh_pwd.c b/src/windows/leashdll/lsh_pwd.c
index 3c965b4..ac85625 100644
--- a/src/windows/leashdll/lsh_pwd.c
+++ b/src/windows/leashdll/lsh_pwd.c
@@ -1506,7 +1506,7 @@ AuthenticateProc(
         SetActiveWindow(hDialog);
         SetForegroundWindow(hDialog);
         /* put focus on password if princ is read-only */
-        hFocusCtrl = bReadOnlyPrinc ?
+        hFocusCtrl = (bReadOnlyPrinc || principal[0] != '\0') ?
             GetDlgItem(hDialog, IDC_EDIT_PASSWORD) : hEditCtrl;
         if (((HWND)wParam) != hFocusCtrl) {
             SetFocus(hFocusCtrl);


More information about the cvs-krb5 mailing list