krb5 commit: Fix minor memory leak in klist (again)

Greg Hudson ghudson at mit.edu
Sat Oct 4 19:59:50 EDT 2014


https://github.com/krb5/krb5/commit/319d98bf13e8486f9f378ee47147c9c4bdb15c37
commit 319d98bf13e8486f9f378ee47147c9c4bdb15c37
Author: Greg Hudson <ghudson at mit.edu>
Date:   Wed Aug 27 16:15:46 2014 -0400

    Fix minor memory leak in klist (again)
    
    Commit 6e51f9cc3152c8e419fe7f459bcf521d60358434 attempted to fix two
    minor memory leaks in klist, but one of the fixes was dead code.  In
    do_ccache, free princ before we look at the code which terminated the
    loop, not after we have returned on either branch.

 src/clients/klist/klist.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/clients/klist/klist.c b/src/clients/klist/klist.c
index 51eaa07..9058e8f 100644
--- a/src/clients/klist/klist.c
+++ b/src/clients/klist/klist.c
@@ -533,6 +533,7 @@ do_ccache(krb5_ccache cache)
         }
         krb5_free_cred_contents(kcontext, &creds);
     }
+    krb5_free_principal(kcontext, princ);
     if (code == KRB5_CC_END) {
         if ((code = krb5_cc_end_seq_get(kcontext, cache, &cur))) {
             if (!status_only)
@@ -555,7 +556,6 @@ do_ccache(krb5_ccache cache)
             com_err(progname, code, _("while retrieving a ticket"));
         return 1;
     }
-    krb5_free_principal(kcontext, princ);
 }
 
 char *


More information about the cvs-krb5 mailing list