krb5 commit [krb5-1.12]: Fix fencepost error in krad timeout handler

Tom Yu tlyu at MIT.EDU
Fri Jun 27 12:34:53 EDT 2014


https://github.com/krb5/krb5/commit/01987783006ba486b0a5772db9d40168b6bfdced
commit 01987783006ba486b0a5772db9d40168b6bfdced
Author: Greg Hudson <ghudson at mit.edu>
Date:   Sat May 17 10:48:50 2014 -0400

    Fix fencepost error in krad timeout handler
    
    (cherry picked from commit f4fce5afd8c4bb5e46aa7041f10118026c5152f0)
    
    ticket: 7911
    version_fixed: 1.12.2
    status: resolved

 src/lib/krad/remote.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krad/remote.c b/src/lib/krad/remote.c
index bb7c061..bea1429 100644
--- a/src/lib/krad/remote.c
+++ b/src/lib/krad/remote.c
@@ -243,7 +243,7 @@ on_timeout(verto_ctx *ctx, verto_ev *ev)
     req->timer = NULL;          /* Void the timer event. */
 
     /* If we have more retries to perform, resend the packet. */
-    if (req->retries-- > 1) {
+    if (req->retries-- > 0) {
         req->sent = 0;
         retval = remote_add_flags(req->rr, FLAGS_WRITE);
         if (retval == 0)


More information about the cvs-krb5 mailing list