krb5 commit: Fix argment validation in krb5_make_fulladdr

Greg Hudson ghudson at MIT.EDU
Sat Jul 12 15:19:26 EDT 2014


https://github.com/krb5/krb5/commit/347e70a0649d976f10236d682ee4999569b964d4
commit 347e70a0649d976f10236d682ee4999569b964d4
Author: Lukas Slebodnik <lslebodn at redhat.com>
Date:   Sat Jun 21 16:11:31 2014 +0200

    Fix argment validation in krb5_make_fulladdr
    
    Check kaddr and kport, not kport twice.
    
    [ghudson at mit.edu: clarified commit message, minor style change]

 src/lib/krb5/os/mk_faddr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/os/mk_faddr.c b/src/lib/krb5/os/mk_faddr.c
index 7e125cf..2577df3 100644
--- a/src/lib/krb5/os/mk_faddr.c
+++ b/src/lib/krb5/os/mk_faddr.c
@@ -42,7 +42,7 @@ krb5_make_fulladdr(krb5_context context, krb5_address *kaddr,
     krb5_int32 tmp32;
     krb5_int16 tmp16;
 
-    if ((kport == NULL) || (kport == NULL))
+    if (kaddr == NULL || kport == NULL)
         return EINVAL;
 
     raddr->length = kaddr->length + kport->length + (4 * sizeof(krb5_int32));


More information about the cvs-krb5 mailing list