krb5 commit: Clean up rcache if GSS krb5 acquire_cred fails

Greg Hudson ghudson at MIT.EDU
Fri Jan 17 15:58:53 EST 2014


https://github.com/krb5/krb5/commit/9df0c4bdce6b88a01af51e4bbb9a365db00256d5
commit 9df0c4bdce6b88a01af51e4bbb9a365db00256d5
Author: Greg Hudson <ghudson at mit.edu>
Date:   Wed Jan 15 14:41:54 2014 -0500

    Clean up rcache if GSS krb5 acquire_cred fails
    
    The error handler in acquire_cred_context didn't release the rcache,
    which would cause it to leak if we failed after acquire_accept_cred.
    
    ticket: 7818 (new)
    target_version: 1.12.2
    tags: pullup

 src/lib/gssapi/krb5/acquire_cred.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 37cc6b5..f625c0c 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -829,6 +829,8 @@ error_out:
         if (cred->keytab)
             krb5_kt_close(context, cred->keytab);
 #endif /* LEAN_CLIENT */
+        if (cred->rcache)
+            krb5_rc_close(context, cred->rcache);
         if (cred->name)
             kg_release_name(context, &cred->name);
         k5_mutex_destroy(&cred->lock);


More information about the cvs-krb5 mailing list