krb5 commit [krb5-1.11]: Fix memory leak in patch for #7831

Tom Yu tlyu at MIT.EDU
Fri Feb 21 15:04:37 EST 2014


https://github.com/krb5/krb5/commit/665b72334a9b2d0423b70fc3901b194831a2c0db
commit 665b72334a9b2d0423b70fc3901b194831a2c0db
Author: Tom Yu <tlyu at mit.edu>
Date:   Fri Feb 21 15:04:10 2014 -0500

    Fix memory leak in patch for #7831
    
    The patch for #7831 included a change to do_as_req.c that was only
    needed in krb5-1.12; applying it to krb5-1.11 duplicated a block of
    code and led to a memory leak.
    
    ticket: 7867 (new)
    version_fixed: 1.11.6
    status: resolved

 src/kdc/do_as_req.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c
index 2757492..79da300 100644
--- a/src/kdc/do_as_req.c
+++ b/src/kdc/do_as_req.c
@@ -524,19 +524,6 @@ process_as_req(krb5_kdc_req *request, krb5_data *req_pkt,
     }
     limit_string(state->sname);
 
-    if (!state->request->server) {
-        state->status = "NULL_SERVER";
-        errcode = KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN;
-        goto errout;
-    }
-    if ((errcode = krb5_unparse_name(kdc_context,
-                                     state->request->server,
-                                     &state->sname))) {
-        state->status = "UNPARSING_SERVER";
-        goto errout;
-    }
-    limit_string(state->sname);
-
     /*
      * We set KRB5_KDB_FLAG_CLIENT_REFERRALS_ONLY as a hint
      * to the backend to return naming information in lieu


More information about the cvs-krb5 mailing list