krb5 commit: Remove rtm_type_name()

Benjamin Kaduk kaduk at MIT.EDU
Mon Nov 4 14:22:24 EST 2013


https://github.com/krb5/krb5/commit/bcc91c8d8b3d5b775cfde1ee461d7e0394070852
commit bcc91c8d8b3d5b775cfde1ee461d7e0394070852
Author: Ben Kaduk <kaduk at mit.edu>
Date:   Fri Nov 1 15:12:33 2013 -0400

    Remove rtm_type_name()
    
    It has been unused since 2009 when Ken decided that the routing log
    messages were too verbose (commit 91fc077c96926dd60).

 src/lib/apputils/net-server.c |   37 -------------------------------------
 1 files changed, 0 insertions(+), 37 deletions(-)

diff --git a/src/lib/apputils/net-server.c b/src/lib/apputils/net-server.c
index b4be585..d19d45a 100644
--- a/src/lib/apputils/net-server.c
+++ b/src/lib/apputils/net-server.c
@@ -983,32 +983,6 @@ setup_udp_port(void *P_data, struct sockaddr *addr)
 #ifdef HAVE_STRUCT_RT_MSGHDR
 #include <net/route.h>
 
-#if 0
-static char *
-rtm_type_name(int type)
-{
-    switch (type) {
-    case RTM_ADD: return "RTM_ADD";
-    case RTM_DELETE: return "RTM_DELETE";
-    case RTM_NEWADDR: return "RTM_NEWADDR";
-    case RTM_DELADDR: return "RTM_DELADDR";
-    case RTM_IFINFO: return "RTM_IFINFO";
-    case RTM_OLDADD: return "RTM_OLDADD";
-    case RTM_OLDDEL: return "RTM_OLDDEL";
-    case RTM_RESOLVE: return "RTM_RESOLVE";
-#ifdef RTM_NEWMADDR
-    case RTM_NEWMADDR: return "RTM_NEWMADDR";
-    case RTM_DELMADDR: return "RTM_DELMADDR";
-#endif
-    case RTM_MISS: return "RTM_MISS";
-    case RTM_REDIRECT: return "RTM_REDIRECT";
-    case RTM_LOSING: return "RTM_LOSING";
-    case RTM_GET: return "RTM_GET";
-    default: return "?";
-    }
-}
-#endif
-
 static void
 do_network_reconfig(verto_ctx *ctx, verto_ev *ev)
 {
@@ -1054,11 +1028,6 @@ routing_update_needed(struct rt_msghdr *rtm)
         if (rtm->rtm_flags & RTF_LLINFO)
             break;
 #endif
-#if 0
-        krb5_klog_syslog(LOG_DEBUG,
-                         "network reconfiguration message (%s) received",
-                         rtm_type_name(rtm->rtm_type));
-#endif
         return 1;
     case RTM_RESOLVE:
 #ifdef RTM_NEWMADDR
@@ -1115,12 +1084,6 @@ process_routing_update(verto_ctx *ctx, verto_ev *ev)
                 return;
             }
         }
-#if 0
-        krb5_klog_syslog(LOG_INFO,
-                         _("got routing msg type %d(%s) v%d"),
-                         rtm.rtm_type, rtm_type_name(rtm.rtm_type),
-                         rtm.rtm_version);
-#endif
         if (rtm.rtm_msglen > sizeof(rtm)) {
             /* It appears we get a partial message and the rest is
                thrown away?  */


More information about the cvs-krb5 mailing list