krb5 commit: Fix a typo that caused us to not skip removing "."

Greg Hudson ghudson at MIT.EDU
Wed May 8 01:17:43 EDT 2013


https://github.com/krb5/krb5/commit/1e7d7018e7a29c91c86ce4222cff9e44cf8b62a2
commit 1e7d7018e7a29c91c86ce4222cff9e44cf8b62a2
Author: Nalin Dahyabhai <nalin at redhat.com>
Date:   Tue Apr 30 17:37:22 2013 -0400

    Fix a typo that caused us to not skip removing "."
    
    When attempting to clean the files out from our temporary directory,
    correct the test which was supposed to let us skip over "." and ".." so
    that we actually don't try to remove them with remove().

 src/plugins/preauth/pkinit/pkinit_crypto_nss.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/plugins/preauth/pkinit/pkinit_crypto_nss.c b/src/plugins/preauth/pkinit/pkinit_crypto_nss.c
index b33ce74..ec6db2d 100644
--- a/src/plugins/preauth/pkinit/pkinit_crypto_nss.c
+++ b/src/plugins/preauth/pkinit/pkinit_crypto_nss.c
@@ -745,7 +745,7 @@ crypto_get_p12_slot(struct _pkinit_identity_crypto_context *id)
                          __FUNCTION__, configdir, strerror(errno));
             else {
                 while ((ent = readdir(dir)) != NULL) {
-                    if ((strcmp(ent->d_name, ".") == 0) &&
+                    if ((strcmp(ent->d_name, ".") == 0) ||
                         (strcmp(ent->d_name, "..") == 0)) {
                         continue;
                     }


More information about the cvs-krb5 mailing list