krb5 commit: Fix void pointer arithmetic in oid_ops.c

Greg Hudson ghudson at MIT.EDU
Wed Jan 9 10:08:38 EST 2013


https://github.com/krb5/krb5/commit/fc20ae13f18260930433d6239554f24bb50312a3
commit fc20ae13f18260930433d6239554f24bb50312a3
Author: Greg Hudson <ghudson at mit.edu>
Date:   Wed Jan 9 10:07:27 2013 -0500

    Fix void pointer arithmetic in oid_ops.c
    
    When asserting that out has advanced the expected number of bytes in
    generic_gss_str_to_oid, avoid adding to oid->elements, which is a void
    pointer.  Instead subtract from out and compare.
    
    ticket: 7524

 src/lib/gssapi/generic/oid_ops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/gssapi/generic/oid_ops.c b/src/lib/gssapi/generic/oid_ops.c
index a088734..a03b6f8 100644
--- a/src/lib/gssapi/generic/oid_ops.c
+++ b/src/lib/gssapi/generic/oid_ops.c
@@ -406,7 +406,7 @@ generic_gss_str_to_oid(OM_uint32 *minor_status,
     p = arc3_start;
     while (get_arc(&p, end, &arc))
         arc_encode(arc, &out);
-    assert(out == oid->elements + nbytes);
+    assert(out - nbytes == oid->elements);
     *oid_out = oid;
     return(GSS_S_COMPLETE);
 }


More information about the cvs-krb5 mailing list