krb5 commit: krb5_db_delete_principal() can fail to unlock ulog

Greg Hudson ghudson at MIT.EDU
Mon Oct 8 11:50:23 EDT 2012


https://github.com/krb5/krb5/commit/e41971145349e1f55b6cb3336c014bd8edcb22da
commit e41971145349e1f55b6cb3336c014bd8edcb22da
Author: Nicolas Williams <nico at cryptonector.com>
Date:   Wed Oct 3 17:22:12 2012 -0500

    krb5_db_delete_principal() can fail to unlock ulog
    
    Not really: only when the KDB backend lacks a delete method.  Still.
    
    ticket: 7403

 src/lib/kdb/kdb5.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/lib/kdb/kdb5.c b/src/lib/kdb/kdb5.c
index 3cf116b..d02bb50 100644
--- a/src/lib/kdb/kdb5.c
+++ b/src/lib/kdb/kdb5.c
@@ -986,8 +986,10 @@ krb5_db_delete_principal(krb5_context kcontext, krb5_principal search_for)
         free(princ_name);
     }
 
-    if (v->delete_principal == NULL)
+    if (v->delete_principal == NULL) {
+        ulog_lock(kcontext, KRB5_LOCKMODE_UNLOCK);
         return KRB5_PLUGIN_OP_NOTSUPP;
+    }
 
     status = v->delete_principal(kcontext, search_for);
 


More information about the cvs-krb5 mailing list