krb5 commit: Sync iprop header in kdb5_util dump

Greg Hudson ghudson at MIT.EDU
Fri Oct 5 15:13:07 EDT 2012


https://github.com/krb5/krb5/commit/3221bdba150ac3910dc7058f02c71008ef56bf52
commit 3221bdba150ac3910dc7058f02c71008ef56bf52
Author: Nicolas Williams <nico at cryptonector.com>
Date:   Fri Oct 5 14:56:35 2012 -0400

    Sync iprop header in kdb5_util dump
    
    [ghudson at mit.edu: split out from previous commit]

 src/kadmin/dbutil/dump.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/src/kadmin/dbutil/dump.c b/src/kadmin/dbutil/dump.c
index e72de63..1009679 100644
--- a/src/kadmin/dbutil/dump.c
+++ b/src/kadmin/dbutil/dump.c
@@ -2905,6 +2905,16 @@ load_db(argc, argv)
                     last_seconds;
                 log_ctx->ulog->kdb_last_time.useconds =
                     last_useconds;
+
+                /*
+                 * Sync'ing the header is not necessary on any OS and
+                 * filesystem where the filesystem and virtual memory block
+                 * cache are unified, which is pretty much all cases that we
+                 * care about.  However, technically speaking we must msync()
+                 * in order for our writes here to be visible to a running
+                 * kpropd.
+                 */
+                ulog_sync_header(log_ctx->ulog);
             }
         }
     }


More information about the cvs-krb5 mailing list