svn rev #25783: trunk/src/ kdc/ lib/kadm5/srv/ slave/

ghudson@MIT.EDU ghudson at MIT.EDU
Thu Mar 22 10:07:44 EDT 2012


http://src.mit.edu/fisheye/changelog/krb5/?cs=25783
Commit By: ghudson
Log Message:
Suppress some gcc uninitialized variable warnings
ticket: 7107
gcc 4.6.2 reportedly finds some spurious maybe-uninitialized warnings.
Suppress them.  Patch from Eray Aslan with some adjustment.


Changed Files:
U   trunk/src/kdc/do_as_req.c
U   trunk/src/lib/kadm5/srv/svr_iters.c
U   trunk/src/slave/kprop.c
Modified: trunk/src/kdc/do_as_req.c
===================================================================
--- trunk/src/kdc/do_as_req.c	2012-03-21 17:44:18 UTC (rev 25782)
+++ trunk/src/kdc/do_as_req.c	2012-03-22 14:07:44 UTC (rev 25783)
@@ -191,6 +191,7 @@
      * by request keytype list.
      */
     client_key = NULL;
+    useenctype = 0;
     for (i = 0; i < state->request->nktypes; i++) {
         useenctype = state->request->ktype[i];
         if (!krb5_c_valid_enctype(useenctype))

Modified: trunk/src/lib/kadm5/srv/svr_iters.c
===================================================================
--- trunk/src/lib/kadm5/srv/svr_iters.c	2012-03-21 17:44:18 UTC (rev 25782)
+++ trunk/src/lib/kadm5/srv/svr_iters.c	2012-03-22 14:07:44 UTC (rev 25783)
@@ -187,7 +187,7 @@
 #ifdef BSD_REGEXPS
     char *msg;
 #endif
-    char *regexp;
+    char *regexp = NULL;
     int i, ret;
     kadm5_server_handle_t handle = server_handle;
 

Modified: trunk/src/slave/kprop.c
===================================================================
--- trunk/src/slave/kprop.c	2012-03-21 17:44:18 UTC (rev 25782)
+++ trunk/src/slave/kprop.c	2012-03-22 14:07:44 UTC (rev 25783)
@@ -310,7 +310,7 @@
 }
 
 static void
-open_connection(krb5_context context, char *host, int *fd)
+open_connection(krb5_context context, char *host, int *fd_out)
 {
     int     s;
     krb5_error_code retval;
@@ -320,6 +320,7 @@
     struct sockaddr_storage my_sin;
     int error;
 
+    *fd_out = -1;
     memset(&hints, 0, sizeof(hints));
     hints.ai_family = PF_UNSPEC;
     hints.ai_socktype = SOCK_STREAM;
@@ -347,7 +348,7 @@
         }
 
         /* We successfully connect()ed */
-        *fd = s;
+        *fd_out = s;
         retval = sockaddr2krbaddr(context, res->ai_family, res->ai_addr,
                                   &receiver_addr);
         if (retval != 0) {



More information about the cvs-krb5 mailing list