krb5 commit: Don't free caller's principal in vfy_increds

Greg Hudson ghudson at MIT.EDU
Wed Jun 6 19:13:27 EDT 2012


https://github.com/krb5/krb5/commit/dd64191e02df0a13b29345e4c50fe03e039dc207
commit dd64191e02df0a13b29345e4c50fe03e039dc207
Author: Greg Hudson <ghudson at mit.edu>
Date:   Wed Jun 6 19:13:13 2012 -0400

    Don't free caller's principal in vfy_increds
    
    #7125 took out the copy of the krb5_verify_init_creds server argument
    but left in the corresponding free, so it was freeing a caller-owned
    principal.  Reported by Russ Allbery.
    
    ticket: 7162

 src/lib/krb5/krb/vfy_increds.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/krb/vfy_increds.c b/src/lib/krb5/krb/vfy_increds.c
index 5fca700..14acb0a 100644
--- a/src/lib/krb5/krb/vfy_increds.c
+++ b/src/lib/krb5/krb/vfy_increds.c
@@ -317,7 +317,6 @@ cleanup:
 
     if (defkeytab != NULL)
         krb5_kt_close(context, defkeytab);
-    krb5_free_principal(context, server);
     free_princ_list(context, host_princs);
 
     return ret;


More information about the cvs-krb5 mailing list