krb5 commit: Leave 'OK' button visible in Leash AboutBox

Benjamin Kaduk kaduk at MIT.EDU
Wed Dec 5 14:28:22 EST 2012


https://github.com/krb5/krb5/commit/ceb486df4301608d5b2462011fed6534e60721bd
commit ceb486df4301608d5b2462011fed6534e60721bd
Author: Ben Kaduk <kaduk at mit.edu>
Date:   Mon Dec 3 12:25:07 2012 -0500

    Leave 'OK' button visible in Leash AboutBox
    
    The AboutBox dialog as specified in the resource file is larger than
    the one we display; the dialog init routine marks several things as
    non-visible, moves the 'OK' button up to where the now-invisible items
    were, and shrinks the dialog's bounding rectangle.
    
    However, the edit boxes containing copyright and version information
    seem to always present as being on top of the 'OK' button, and their
    background causes the button to appear almost invisible with the current
    repositioning.
    
    To keep the 'OK' button visible, reduce the amount that it is moved
    (and the amount the dialog is shrunk) so that the button does not overlap
    with the edit box.
    
    ticket: 7443
    tags: pullup
    target_version: 1.10.4

 src/windows/leash/LeashAboutBox.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/windows/leash/LeashAboutBox.cpp b/src/windows/leash/LeashAboutBox.cpp
index 632dc59..d5c6be2 100644
--- a/src/windows/leash/LeashAboutBox.cpp
+++ b/src/windows/leash/LeashAboutBox.cpp
@@ -268,7 +268,7 @@ BOOL CLeashAboutBox::OnInitDialog()
         GetDlgItem(IDC_STATIC_NO_OF_MODULES)->ShowWindow(SW_HIDE);
         m_LB_DLLsLoaded.ShowWindow(SW_HIDE);
         // shrink window, move 'OK' button
-        const int hideDiff = 175;
+        const int hideDiff = 150;
         RECT okRect;
         CWnd* pOK = GetDlgItem(IDOK);
         pOK->GetWindowRect(&okRect);


More information about the cvs-krb5 mailing list