svn rev #25146: trunk/src/ lib/apputils/ lib/kadm5/ lib/kdb/ lib/krb5/krb/ lib/krb5/os/ ...

raeburn@MIT.EDU raeburn at MIT.EDU
Sun Sep 4 21:21:55 EDT 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=25146
Commit By: raeburn
Log Message:
Silence various "may be used uninitialized" warnings from GCC caused
by it not figuring out the control flow (initialization and use both
tied to some other variable).

DB2 code not included.


Changed Files:
U   trunk/src/lib/apputils/net-server.c
U   trunk/src/lib/kadm5/str_conv.c
U   trunk/src/lib/kdb/kdb_default.c
U   trunk/src/lib/krb5/krb/authdata.c
U   trunk/src/lib/krb5/krb/send_tgs.c
U   trunk/src/lib/krb5/os/sendto_kdc.c
U   trunk/src/lib/rpc/svc_tcp.c
U   trunk/src/lib/rpc/svc_udp.c
U   trunk/src/plugins/preauth/pkinit/pkinit_srv.c
U   trunk/src/tests/create/kdb5_mkdums.c
U   trunk/src/tests/verify/kdb5_verify.c
Modified: trunk/src/lib/apputils/net-server.c
===================================================================
--- trunk/src/lib/apputils/net-server.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/apputils/net-server.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -1652,7 +1652,7 @@
 static int
 kill_lru_tcp_or_rpc_connection(void *handle, verto_ev *newev)
 {
-    struct connection *c, *oldest_c = NULL;
+    struct connection *c = NULL, *oldest_c = NULL;
     verto_ev *ev, *oldest_ev = NULL;
     int i, fd = -1;
 

Modified: trunk/src/lib/kadm5/str_conv.c
===================================================================
--- trunk/src/lib/kadm5/str_conv.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/kadm5/str_conv.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -261,7 +261,7 @@
 {
     krb5_error_code     kret;
     char                *kp, *sp, *ep;
-    char                sepchar, trailchar;
+    char                sepchar = 0, trailchar = 0;
     krb5_enctype        ktype;
     krb5_int32          stype;
     krb5_key_salt_tuple *savep;

Modified: trunk/src/lib/kdb/kdb_default.c
===================================================================
--- trunk/src/lib/kdb/kdb_default.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/kdb/kdb_default.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -74,6 +74,7 @@
     }
 
     maxkvno = -1;
+    idx = -1;
     datap = (krb5_key_data *) NULL;
     for (i = *start; i < dbentp->n_key_data; i++) {
         krb5_boolean    similar;

Modified: trunk/src/lib/krb5/krb/authdata.c
===================================================================
--- trunk/src/lib/krb5/krb/authdata.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/krb5/krb/authdata.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -71,7 +71,7 @@
     int j, k = *module_count;
     krb5_error_code code;
     void *plugin_context = NULL;
-    void **rcpp;
+    void **rcpp = NULL;
 
     if (table->ad_type_list == NULL) {
 #ifdef DEBUG

Modified: trunk/src/lib/krb5/krb/send_tgs.c
===================================================================
--- trunk/src/lib/krb5/krb/send_tgs.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/krb5/krb/send_tgs.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -168,7 +168,7 @@
 {
     krb5_error_code retval;
     krb5_kdc_req tgsreq;
-    krb5_data *scratch, scratch2;
+    krb5_data *scratch, scratch2 = empty_data();
     krb5_ticket *sec_ticket = NULL;
     krb5_ticket *sec_ticket_arr[2];
     krb5_timestamp time_now;

Modified: trunk/src/lib/krb5/os/sendto_kdc.c
===================================================================
--- trunk/src/lib/krb5/os/sendto_kdc.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/krb5/os/sendto_kdc.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -1146,7 +1146,7 @@
             int (*msg_handler)(krb5_context, const krb5_data *, void *),
             void *msg_handler_data, struct conn_state **winner_out)
 {
-    int e, selret;
+    int e, selret = 0;
     struct timeval now;
     struct conn_state *state;
 

Modified: trunk/src/lib/rpc/svc_tcp.c
===================================================================
--- trunk/src/lib/rpc/svc_tcp.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/rpc/svc_tcp.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -492,8 +492,8 @@
 	register XDR *xdrs = &(cd->xdrs);
 	register bool_t stat;
 
-	xdrproc_t xdr_results;
-	caddr_t xdr_location;
+	xdrproc_t xdr_results = NULL;
+	caddr_t xdr_location = 0;
 	bool_t has_args;
 
 	if (msg->rm_reply.rp_stat == MSG_ACCEPTED &&

Modified: trunk/src/lib/rpc/svc_udp.c
===================================================================
--- trunk/src/lib/rpc/svc_udp.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/lib/rpc/svc_udp.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -242,8 +242,8 @@
      register int slen;
      register bool_t stat = FALSE;
 
-     xdrproc_t xdr_results;
-     caddr_t xdr_location;
+     xdrproc_t xdr_results = NULL;
+     caddr_t xdr_location = 0;
      bool_t has_args;
 
      if (msg->rm_reply.rp_stat == MSG_ACCEPTED &&

Modified: trunk/src/plugins/preauth/pkinit/pkinit_srv.c
===================================================================
--- trunk/src/plugins/preauth/pkinit/pkinit_srv.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/plugins/preauth/pkinit/pkinit_srv.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -306,7 +306,7 @@
     krb5_auth_pack *auth_pack = NULL;
     krb5_auth_pack_draft9 *auth_pack9 = NULL;
     pkinit_kdc_context plgctx = NULL;
-    pkinit_kdc_req_context reqctx;
+    pkinit_kdc_req_context reqctx = NULL;
     krb5_preauthtype pa_type;
     krb5_checksum cksum = {0, 0, 0, NULL};
     krb5_data *der_req = NULL;

Modified: trunk/src/tests/create/kdb5_mkdums.c
===================================================================
--- trunk/src/tests/create/kdb5_mkdums.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/tests/create/kdb5_mkdums.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -97,7 +97,7 @@
     int num_to_create;
     char principal_string[BUFSIZ];
     char *suffix = 0;
-    size_t suffix_size;
+    size_t suffix_size = 0;
     int depth;
 
     krb5_init_context(&test_context);

Modified: trunk/src/tests/verify/kdb5_verify.c
===================================================================
--- trunk/src/tests/verify/kdb5_verify.c	2011-09-05 01:21:50 UTC (rev 25145)
+++ trunk/src/tests/verify/kdb5_verify.c	2011-09-05 01:21:55 UTC (rev 25146)
@@ -93,7 +93,7 @@
     int num_to_check;
     char principal_string[BUFSIZ];
     char *suffix = 0;
-    size_t suffix_size;
+    size_t suffix_size = 0;
     int depth, errors;
 
     krb5_init_context(&context);




More information about the cvs-krb5 mailing list