svn rev #25464: branches/krb5-1-8/src/kadmin/cli/

tlyu@MIT.EDU tlyu at MIT.EDU
Tue Nov 8 17:21:37 EST 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=25464
Commit By: tlyu
Log Message:
ticket: 7012
version_fixed: 1.8.6
status: resolved

pull up r25444 from trunk

 ------------------------------------------------------------------------
 r25444 | ghudson | 2011-11-06 00:32:34 -0500 (Sun, 06 Nov 2011) | 10 lines

 ticket: 7003
 subject: Fix month/year units in getdate
 target_version: 1.10
 tags: pullup

 getdate strings like "1 month" or "next year" would fail some of the
 time, depending on the value of stack garbage, because DSTcorrect()
 doesn't set *error on success and RelativeMonth() doesn't initialize
 error.  Make DSTcorrect() responsible for setting *error in all cases.


Changed Files:
U   branches/krb5-1-8/src/kadmin/cli/getdate.y
Modified: branches/krb5-1-8/src/kadmin/cli/getdate.y
===================================================================
--- branches/krb5-1-8/src/kadmin/cli/getdate.y	2011-11-08 22:21:33 UTC (rev 25463)
+++ branches/krb5-1-8/src/kadmin/cli/getdate.y	2011-11-08 22:21:36 UTC (rev 25464)
@@ -646,6 +646,7 @@
 	return -1;
     }
     FutureDay = (tm->tm_hour + 1) % 24;
+    *error = 0;
     return (Future - Start) + (StartDay - FutureDay) * 60L * 60L;
 }
 
@@ -896,7 +897,7 @@
     time_t		Start;
     time_t		tod;
     time_t		delta;
-    int			error = 0;
+    int			error;
 
     yyInput = p;
     if (now == NULL) {




More information about the cvs-krb5 mailing list