svn rev #24755: trunk/src/kadmin/server/

ghudson@MIT.EDU ghudson at MIT.EDU
Tue Mar 29 18:44:30 EDT 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=24755
Commit By: ghudson
Log Message:
ticket: 6888
target_version: 1.9.1
tags: pullup

In r21175 (on the mskrb branch, merged in r21690) the result codes for
password quality and other errors were accidentally reversed.  Fix
them so that password quality errors generate a "soft" failure and
other errors generate a "hard" failure, as Heimdal and Microsoft do.
Also recognize KADM5_PASS_Q_GENERIC (added in 1.9) as a password
quality error.



Changed Files:
U   trunk/src/kadmin/server/schpw.c
Modified: trunk/src/kadmin/server/schpw.c
===================================================================
--- trunk/src/kadmin/server/schpw.c	2011-03-29 18:52:22 UTC (rev 24754)
+++ trunk/src/kadmin/server/schpw.c	2011-03-29 22:44:30 UTC (rev 24755)
@@ -330,15 +330,16 @@
     case KADM5_PASS_REUSE:
     case KADM5_PASS_Q_CLASS:
     case KADM5_PASS_Q_DICT:
+    case KADM5_PASS_Q_GENERIC:
     case KADM5_PASS_TOOSOON:
-        numresult = KRB5_KPASSWD_HARDERROR;
+        numresult = KRB5_KPASSWD_SOFTERROR;
         break;
     case 0:
         numresult = KRB5_KPASSWD_SUCCESS;
         strlcpy(strresult, "", sizeof(strresult));
         break;
     default:
-        numresult = KRB5_KPASSWD_SOFTERROR;
+        numresult = KRB5_KPASSWD_HARDERROR;
         break;
     }
 




More information about the cvs-krb5 mailing list