svn rev #25046: trunk/src/util/ss/

ghudson@MIT.EDU ghudson at MIT.EDU
Mon Jul 25 11:54:36 EDT 2011


http://src.mit.edu/fisheye/changelog/krb5/?cs=25046
Commit By: ghudson
Log Message:
Fix a premature free in ss_listen().

The readline support change freed input just after ss_execute_line(),
but input can be used in the error block immediately following.  Free
input after the error block instead.


Changed Files:
U   trunk/src/util/ss/listen.c
Modified: trunk/src/util/ss/listen.c
===================================================================
--- trunk/src/util/ss/listen.c	2011-07-25 15:54:33 UTC (rev 25045)
+++ trunk/src/util/ss/listen.c	2011-07-25 15:54:36 UTC (rev 25046)
@@ -135,7 +135,6 @@
 #endif
 
         code = ss_execute_line (sci_idx, input);
-        free(input);
         if (code == SS_ET_COMMAND_NOT_FOUND) {
             register char *c = input;
             while (*c == ' ' || *c == '\t')
@@ -150,6 +149,7 @@
                       "Unknown request \"%s\".  Type \"?\" for a request list.",
                       c);
         }
+        free(input);
     }
     code = 0;
 egress:




More information about the cvs-krb5 mailing list